Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bibtexparser/middlewares/interpolate.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ def transform(self, library: Library) -> Library:
if not self.allow_inplace_modification:
library = deepcopy(library)

# BibTeX string keys are case-insensitive; later definitions win.
string_values = {key.lower(): s.value for key, s in library.strings_dict.items()}

entry: Entry
raised_enclosing_warning = False
for entry in library.entries:
Expand All @@ -58,9 +61,10 @@ def transform(self, library: Library) -> Library:
for field in entry.fields:
if _value_is_nonstring_or_enclosed(field.value):
continue
if field.value not in library.strings_dict:
try:
field.value = string_values[field.value.lower()]
except KeyError:
continue
field.value = library.strings_dict[field.value].value
resolved_fields.append(field.key)

if resolved_fields:
Expand Down
20 changes: 20 additions & 0 deletions tests/middleware_tests/test_interpolate.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,26 @@ def test_string_interpolation_middleware_interpolates_string():
)


def test_string_interpolation_is_case_insensitive():
bibtex = """
@string{lowercase = "Lower Case Note."}
@string{UPPERCASE = "Upper Case Note."}

@article{test_article,
note = LOWERCASE,
comment = uppercase
}
"""
library = Splitter(bibtex).split()

m = ResolveStringReferencesMiddleware()
library = m.transform(library)

fields = library.entries_dict["test_article"].fields_dict
assert fields["note"].value == '"Lower Case Note."'
assert fields["comment"].value == '"Upper Case Note."'


def test_warning_is_raised_if_enclosings_are_removed():
original_lib = Splitter(bibtex_string).split()
m = RemoveEnclosingMiddleware(allow_inplace_modification=False)
Expand Down
Loading