🐛 Resolve @string references case-insensitively#559
Merged
Conversation
BibTeX treats string (macro) keys as case-insensitive, but
ResolveStringReferencesMiddleware did an exact dict lookup, so
e.g. `month = JAN` did not resolve against `@string{jan = ...}`.
Build a casefolded lookup once per transform; on keys differing
only in case, the later definition wins, matching BibTeX
redefinition semantics.
Fixes #541
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541
BibTeX downcases macro names when reading them, so
@stringkeys are case-insensitive (e.g.month = JANresolves against the style-definedjan).ResolveStringReferencesMiddlewaredid an exact, case-sensitive lookup inlibrary.strings_dict, so such references were silently left unresolved.Changes
{key.lower(): value}lookup once pertransformand match field values viafield.value.lower(). Side benefit: avoids callingstrings_dict(which copies the dict) up to twice per field.@stringblocks differ only in case, the later definition wins, matching BibTeX redefinition semantics.Out of scope
Libraryduplicate-key detection still compares string keys case-sensitively (@string{jan=...}+@string{JAN=...}is not flagged). That changes publicLibrarybehavior and deserves its own discussion/PR.🤖 Generated with Claude Code