Skip to content

[codex] Fix failing tests and timeouts#168

Draft
tkilias wants to merge 22 commits into
mainfrom
pr1/fix-failing-tests-and-timeouts
Draft

[codex] Fix failing tests and timeouts#168
tkilias wants to merge 22 commits into
mainfrom
pr1/fix-failing-tests-and-timeouts

Conversation

@tkilias

@tkilias tkilias commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

What changed

This PR collects the stability and robustness fixes needed to make the failing lifecycle checks reviewable on their own.

It includes:

  • database deletion polling fixes and longer delete polling timeouts
  • allowed IP lifecycle polling fixes and longer allowed IP polling timeouts
  • debug logging around API helper responses used to diagnose flaky integration behavior
  • hardened generated ApiError parsing so malformed backend error payloads do not crash error handling

Why it changed

The original branch mixed test-stability work, workflow changes, feature work, and refactoring. This PR isolates the behavioral fixes that address flaky deletion and allowed-IP polling, plus the API error hardening that supports those flows.

Impact

This should make the handwritten access helpers and their related tests more resilient to transitional backend states and malformed error responses.

Validation

  • poetry run pytest -q test/unit/test_api_access.py test/unit/test_ensure_type.py
  • poetry run nox -s format:check
  • poetry run nox -s lint:typing

Integration tests requiring SaaS credentials were not run locally in this publish step.

@tkilias tkilias deployed to manual-approval June 27, 2026 15:20 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant