Skip to content

[codex] Support configurable database node counts#167

Closed
tkilias wants to merge 20 commits into
mainfrom
codex/support-configurable-database-node-counts
Closed

[codex] Support configurable database node counts#167
tkilias wants to merge 20 commits into
mainfrom
codex/support-configurable-database-node-counts

Conversation

@tkilias

@tkilias tkilias commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expose num_nodes in the handwritten OpenApiAccess.create_database() helper
  • forward num_nodes through the OpenApiAccess.database() context helper
  • add unit coverage and a live integration test for the 2-node case

Why

The generated OpenAPI client already supports numNodes, but the handwritten helper layer dropped that field. That prevented SAPIPY users from creating databases with fewer than 4 nodes through the convenience API.

Validation

  • poetry run pytest test/unit/test_api_access.py in Lima VM default
  • integration test added but not executed locally because it requires live SaaS credentials and provisions a real database

Fixes #147

@tkilias tkilias temporarily deployed to manual-approval June 26, 2026 07:03 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 26, 2026 20:35 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 26, 2026 22:54 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 26, 2026 23:43 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 00:44 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 01:08 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 08:34 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 09:05 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 09:52 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 11:27 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 11:49 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 12:02 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 12:09 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to manual-approval June 27, 2026 12:59 — with GitHub Actions Inactive
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tkilias tkilias closed this Jun 27, 2026
@tkilias

tkilias commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator Author

split up into #170 , #168 , #169 , #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable SAPIPY to use less than 4 database nodes

1 participant