-
Notifications
You must be signed in to change notification settings - Fork 32
Clean bad AHDC hits and use ATOF wedges in the Kalman Filter #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
baltzell
merged 11 commits into
JeffersonLab:development
from
ftouchte:sync-coatjava-v2
Jun 12, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2f31211
extends the bank AHDC::kftrack and allow re-cooking of AHDC only
ftouchte 257af6c
convenient use of PID in RK4
ftouchte d8175bb
create KFHit and refactor the kalman filter
ftouchte aae037e
activate atof hit
ftouchte 66abec6
Merge branch 'development' into sync-coatjava-v2
ftouchte 555c315
rename methods
ftouchte 0f2c854
remove unused variables and methods
ftouchte 2e8d722
use a logger
ftouchte 804a964
fix innovation vector for RadialKFHit
ftouchte a2d78ee
cleaning
ftouchte b3770d6
let registerOutputBank removes the banks
ftouchte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 0 additions & 52 deletions
52
reconstruction/alert/src/main/java/org/jlab/rec/ahdc/KalmanFilter/Hit_beam.java
This file was deleted.
Oops, something went wrong.
29 changes: 29 additions & 0 deletions
29
reconstruction/alert/src/main/java/org/jlab/rec/ahdc/KalmanFilter/KFHit.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package org.jlab.rec.ahdc.KalmanFilter; | ||
|
|
||
| import org.apache.commons.math3.linear.RealMatrix; | ||
| import org.apache.commons.math3.linear.RealVector; | ||
| import org.jlab.geom.prim.Point3D; | ||
| /** | ||
| * An interface to unify the hits used the Kalman Filter (e.g AHDC hits, ATOF hits, beamline) | ||
| * | ||
| * @author Felix Touchte Codjo | ||
| */ | ||
| public interface KFHit { | ||
| public double distance(Point3D point3D); | ||
| public double getRadius(); | ||
| /** Return the measurement encoded in this KFHit */ | ||
| public RealVector getMeasurementVector(); | ||
| /** Return the measurement noise matrix for this this KFHit */ | ||
| public RealMatrix getMeasurementNoiseMatrix(); | ||
| /** Compute the measurement for a given state vector */ | ||
| public RealVector getProjectionVector(RealVector x); | ||
| /** Compute the Jacobian matrix of the {@link #getProjectionVector(RealVector)} with respect of the components of the state vector */ | ||
| public RealMatrix getProjectionMatrix(RealVector x); | ||
|
|
||
| /** | ||
| * Compute the innovation by subtracting {@link #getMeasurementVector()} and {@link #getProjectionVector(RealVector)} | ||
| * @param x current state estimation | ||
| * @return return the innovation vector | ||
| */ | ||
| public RealVector getInnovationVector(RealVector x); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.