Skip to content

Clean bad AHDC hits and use ATOF wedges in the Kalman Filter#1309

Merged
baltzell merged 11 commits into
JeffersonLab:developmentfrom
ftouchte:sync-coatjava-v2
Jun 12, 2026
Merged

Clean bad AHDC hits and use ATOF wedges in the Kalman Filter#1309
baltzell merged 11 commits into
JeffersonLab:developmentfrom
ftouchte:sync-coatjava-v2

Conversation

@ftouchte

@ftouchte ftouchte commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Features:

  • Make the Kalman Filter reusable (store error covariance matrix in Track)
  • Add a routine to clean bad AHDC hits
  • Use ATOF wedge in the Kalman Filter
  • Extends AHDC::kftrack
  • Convenient use of the PID in RungeKutta.java

Code consistency:

  • Create an interface for the hits used by the Kalman Filter : KFHit
    • AHDC hits are stored in the usual Hit
    • beamline, ATOF wedges/bars are stored in RadialKFHit
    • the method KFitter.correct() no longer needs to explicitly check if we works with an AHDC hits or not: the polymorphism do the job for use
  • Remove redundancy : KFitter does not use another Stepper in its constructor (the initial Stepper and the initial state are linked)

This pull request is the sync version of this draft : #1117

In coatjava development
image
This PR
image

@ftouchte

Copy link
Copy Markdown
Collaborator Author

Hello everyone, this pull request is ready for review.

I'm waiting for this PR to get validated before submitting the next one about the alignment: #1310

@mathieuouillon

mathieuouillon commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

I've added a few comments. Sorry, I forgot to send them.

Comment thread etc/bankdefs/hipo4/alert.json
Comment thread reconstruction/alert/src/main/java/org/jlab/rec/ahdc/KalmanFilter/KFitter.java Outdated
mathieuouillon
mathieuouillon previously approved these changes Jun 11, 2026
Comment thread reconstruction/alert/src/main/java/org/jlab/service/ahdc/AHDCEngine.java Outdated
@baltzell baltzell merged commit 1bd4e65 into JeffersonLab:development Jun 12, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants