feat(settings): add collapsible sidebar feature flag and user settings#714
Open
dembrane-sam-bot wants to merge 1 commit into
Open
feat(settings): add collapsible sidebar feature flag and user settings#714dembrane-sam-bot wants to merge 1 commit into
dembrane-sam-bot wants to merge 1 commit into
Conversation
Implement support for collapsible sidebar under app_user.settings. Add Beta features section under User Settings (Appearance tab) with a checkbox to toggle on/off. Handle collapsible sidebar toggling in AppSidebar, SidebarHeader, and BaseLayout, adjusting breadcrumbs padding dynamically. Refs: ECHO-864
|
Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsible Sidebar Feature Flag
Implement support for collapsible sidebar under user-specific feature flags (app_user.settings), default off. Added a "Beta features" card inside the user Settings -> Appearance tab with a checkbox to opt-in, plus collapse/expand behavior with responsive padding layout for breadcrumbs.
Discussion: https://dembraneworkspace.slack.com/archives/C0884QPQF6W/p1782215110561439
Refs: ECHO-864
What this changes
settingsJSON field added toapp_userin Directus to store feature flags —add_user_settings_field.py,settings.json/v2/meGET/PATCH updated to serve, modify, and merge user settings —me.py,schemas.py,test_user_settings_flags.pyenable_collapsible_sidebar—BetaFeaturesCard.tsx,UserSettingsRoute.tsxSidebarHeader.tsx,useSidebarState.ts,BaseLayout.tsx,AppBreadcrumbs.tsx,ResizeHandle.tsx,SidebarShell.tsxConfidence
Confidence: high. Complete integration on both backend and frontend layers with full Lingui macro internationalization and dedicated backend unit tests. All modified files compile perfectly.