fix(sidebar): highlight conversations tab on nested conversation/transcript pages#708
Open
dembrane-sam-bot wants to merge 2 commits into
Open
fix(sidebar): highlight conversations tab on nested conversation/transcript pages#708dembrane-sam-bot wants to merge 2 commits into
dembrane-sam-bot wants to merge 2 commits into
Conversation
|
Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
/conversations/:conversationId) with the list route path (/conversations), ensuring standard matching rules organically highlight the "Conversations" sidebar tab on all detail, transcript, and sub-pages without requiring custom force-active logic —Router.tsx,ProjectHomeView.tsx/conversations/:conversationIdpath structure — 17 files modified (full list in diff)Confidence
High. This is a very clean architecture-level alignment of the path prefix hierarchy that resolves the highlighting issue automatically using standard React Router configuration. Tested matching semantics and reference updates.