Skip to content

TASK: Add RedirectMiddleware and make Flow/Neos 7 compatible#8

Open
gerdemann wants to merge 2 commits into
yeebase:masterfrom
gerdemann:Neos7
Open

TASK: Add RedirectMiddleware and make Flow/Neos 7 compatible#8
gerdemann wants to merge 2 commits into
yeebase:masterfrom
gerdemann:Neos7

Conversation

@gerdemann

Copy link
Copy Markdown

No description provided.

bwaidelich
bwaidelich previously approved these changes Apr 14, 2022

@bwaidelich bwaidelich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (by reading)

albe
albe previously approved these changes Apr 14, 2022

@albe albe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree to what Bastian wrote in the old PR. Reads good from what I can see. Thanks a lot for taking it up!

Comment thread composer.json Outdated
@gerdemann gerdemann dismissed stale reviews from albe and bwaidelich via a9e77f4 April 14, 2022 10:00
Co-authored-by: Alexander Berl <a.berl@outlook.com>

@Benjamin-K Benjamin-K left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged, IMO.

@Benjamin-K Benjamin-K left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry, forgot to check viewed files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants