test(fetch-all): track supported node majors, drop node20#286
Merged
Conversation
pkg-fetch 3.6.x no longer publishes prebuilt node20 binaries (it ships 22/24/26), so test-42-fetch-all's hard-coded node20 request 404s in the v3.6 remote cache and then fails the source-build fallback for win/macos on a Linux host. This broke the entire test:host suite (the only suite that runs this host-only test) after the pkg-fetch 3.6.3 bump. Update the fetched node ranges to 22/24 to match the versions pkg-fetch actually ships and the project's supported range (Node 22+).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The entire
test:hostCI suite has been failing onmainsince the pkg-fetch 3.6.3 bump (#277).test:hostis the only job that runs the host-only test set (only-npm);test:22/test:24useno-npmand exclude it, so they stayed green and masked the breakage.The single failing test is
test-42-fetch-all, which hard-codes['node20', 'node22']. pkg-fetch 3.6.x no longer publishes prebuiltnode20binaries (the 3.6 line ships 22/24/26), so the fetch 404s and then fails the source-build fallback:Fix
Update the fetched node ranges to
['node22', 'node24']— the versions pkg-fetch actually ships and the project's supported range (Node 22+). This matches the test's documented purpose ("verifies patches exist for all Node.js versions").Verification
win/linux/macos×x64/arm64matrix the test covers.test-42-fetch-allfailing).test-42-fetch-allalone passes in ~15s.🤖 Generated with Claude Code