Skip to content

test(fetch-all): track supported node majors, drop node20#286

Merged
robertsLando merged 1 commit into
mainfrom
fix/test-42-fetch-all-drop-node20
Jun 24, 2026
Merged

test(fetch-all): track supported node majors, drop node20#286
robertsLando merged 1 commit into
mainfrom
fix/test-42-fetch-all-drop-node20

Conversation

@robertsLando

Copy link
Copy Markdown
Member

Problem

The entire test:host CI suite has been failing on main since the pkg-fetch 3.6.3 bump (#277). test:host is the only job that runs the host-only test set (only-npm); test:22/test:24 use no-npm and exclude it, so they stayed green and masked the breakage.

The single failing test is test-42-fetch-all, which hard-codes ['node20', 'node22']. pkg-fetch 3.6.x no longer publishes prebuilt node20 binaries (the 3.6 line ships 22/24/26), so the fetch 404s and then fails the source-build fallback:

Error! 404: Not Found
Not found in remote cache: {"tag":"v3.6","name":"node-v20.20.2-win-x64"}
Building base binary from source: built-v20.20.2-win-x64
Error! Not able to build for 'win' here, only for 'linux'

Fix

Update the fetched node ranges to ['node22', 'node24'] — the versions pkg-fetch actually ships and the project's supported range (Node 22+). This matches the test's documented purpose ("verifies patches exist for all Node.js versions").

-  const nodeRanges = ['node20', 'node22'];
+  const nodeRanges = ['node22', 'node24'];

Verification

  • Verified node22 + node24 prebuilts exist for the full win/linux/macos × x64/arm64 matrix the test covers.
  • Ran the full host suite locally: 21/21 pass (was 20/21, only test-42-fetch-all failing).
  • test-42-fetch-all alone passes in ~15s.

🤖 Generated with Claude Code

pkg-fetch 3.6.x no longer publishes prebuilt node20 binaries (it ships
22/24/26), so test-42-fetch-all's hard-coded node20 request 404s in the
v3.6 remote cache and then fails the source-build fallback for win/macos
on a Linux host. This broke the entire test:host suite (the only suite
that runs this host-only test) after the pkg-fetch 3.6.3 bump.

Update the fetched node ranges to 22/24 to match the versions pkg-fetch
actually ships and the project's supported range (Node 22+).
@robertsLando robertsLando merged commit 1b0002f into main Jun 24, 2026
28 checks passed
@robertsLando robertsLando deleted the fix/test-42-fetch-all-drop-node20 branch June 24, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant