write-chapter: allow Unicode box-drawing inside fenced diagrams#41
Merged
Conversation
Relax the ASCII-punctuation convention: prose and code stay ASCII, but a fenced diagram (``` block) may use Unicode box-drawing and arrows for a cleaner picture - the commit hook now permits non-ASCII inside fences. Also add a review-checklist item to render the page and check that diagram connectors line up and every descending line has an arrowhead (the defect behind the chapter 3 and 5 flowcharts). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the commit-hook change that now permits non-ASCII inside
```fenced blocks. This relaxes the matching skill convention so generated chapters can draw cleaner diagrams.What changed in
SKILL.mdThe skill text itself stays pure ASCII (it describes the chars by name, doesn't embed them), so the convention is just guidance — nothing about existing chapters changes.
Verification
SKILL.mdhas zero non-ASCII bytes (so this commit passed the hook normally).bunx tsc --noEmitclean andbun x vitepress buildpasses — existing chapters (all ASCII diagrams) are unaffected.Note: this is the convention/guidance side. The enabling change is in the global commit hook (
~/.claude/hooks/check-commit-chars.mjs), which now skips the blocklist for lines inside```fences — that's not in this repo, so it's not part of this PR.🤖 Generated with Claude Code