fix: add numeric keypad hints for weight and repetitions fields on mobile#1273
Open
Mehak-mahajan wants to merge 1 commit into
Open
fix: add numeric keypad hints for weight and repetitions fields on mobile#1273Mehak-mahajan wants to merge 1 commit into
Mehak-mahajan wants to merge 1 commit into
Conversation
Collaborator
|
coverage: 78.394%. remained the same — Mehak-mahajan:fix/numeric-keypad-workout-log into wger-project:master |
rolandgeider
reviewed
Jul 2, 2026
| } | ||
| }, | ||
| htmlInput:{ | ||
| inputMode: 'numeric' |
Member
There was a problem hiding this comment.
better make this a decimal as well (while it's true that you can't do partial repetitions, this field is also used for other units such as "meters", where it does make sense)
Member
|
Hey! Thanks for the PR! I just left you a small nitpick. Another thing, if you have the motivation, do you want to check other places where we enter numbers? We'd have the same problem with the keyboard there as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2409 (wger-project/wger)
Problem
On mobile browsers (iOS Safari, Chrome), the workout log input fields
for repetitions and weight show a full text keyboard instead of a
numeric keypad, making it slower to enter values during workouts.
Solution
Added inputMode hints to the input fields:
This tells mobile browsers to show the appropriate numeric keypad
while preserving existing functionality.
Testing
Tested on mobile browser - numeric keypad now appears when tapping
weight and repetitions fields.