fix: move OOV test cases out of shared test data to fix C++ unit tests#370
Merged
Conversation
The C++ runtime test loads test data from normalizer.txt but uses FSTs built without tag_oov=True. OOV test cases (Korean/Japanese characters) that require <oov> wrapping are moved to a separate file only loaded by the Python test (which uses tag_oov=True). Fixes #368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move OOV (out-of-vocabulary) test cases from
normalizer.txtto a separatenormalizer_tag_oov.txtfile, only loaded by the Python test.Root Cause
The C++ runtime test loads
normalizer.txtbut uses FST files built withouttag_oov=True(the default). The OOV test cases expecting<oov>wrapping always fail. The Python test passes because it usestag_oov=Trueandoverwrite_cache=True.Fix
tn/chinese/test/data/normalizer.txttn/chinese/test/data/normalizer_tag_oov.txtwith the OOV casesTest Plan
Fixes #368