Add per-RPC-method stats (weka_rpc_stats metric)#87
Open
shazad-weka wants to merge 1 commit into
Open
Conversation
Adds get_rpc_stats() following the same pattern as get_fs_io_stats(),
calling stats_show with param={'method': '*'} and per_process=True to
collect RPC stats broken down by method name.
Stats are config-driven via a new rpc_stats: section in export.yml.
Results are exposed as the weka_rpc_stats Prometheus metric with labels:
cluster, stat, method, unit.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_rpc_stats()tocollector.pyusing the sameparampattern as the existingget_fs_io_stats()— callsstats_showwithparam={'method': '*'}andper_process=Trueweka_rpc_statsPrometheus metric with labels:cluster,stat,method,unitrpc_stats:section inexport.yml(same format as existingstats:section)Equivalent CLI command:
```
weka stats --show-internal --stat RPC_ROUNDTRIP_AVG --interval 60 --param="method:*" -s value --per-process
```
Customer configuration
Add to
export.ymland restart the exporter:```yaml
rpc_stats:
RPC_ROUNDTRIP_AVG: microsecs
RPC_RATE: count
```
Test plan
weka_rpc_statsappears in/metricswithmethodlabel populated per RPC methodRPC_ROUNDTRIP_AVGvalues matchweka stats --param="method:*"outputweka_statsandweka_fs_statsmetrics🤖 Generated with Claude Code