Fix MainRecorder invocation in local_build_native.sh#20
Merged
Conversation
The native-image-agent recording step passed only 4 arguments to MainRecorder,
but MainRecorder requires 5 (sbml_file, vcml_file, sim_name, app_name,
output_dir) and otherwise prints usage and exits early — so the local build's
recording step silently captured nothing. Add the missing app_name
("unnamed_spatialGeom"), matching build.py's invocation, so recording actually
runs (including the moving-boundary path).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/local_build_native.shinvokedMainRecorderwith only 4 arguments, butMainRecorder.mainrequires 5 (sbml_file,vcml_file,sim_name,app_name,output_dir) — with fewer it prints a usage message and returns immediately. As a result, the local build'snative-image-agentrecording step silently captured nothing, so a wheel produced byscripts/local_build_native.shcould be missing reflection/resource config that the native image needs at runtime.build.py(used bypoetry build/poetry install) already passes the correct 5 args, so this only affected the standalone shell script.Fix
Add the missing
app_nameargument (unnamed_spatialGeom, matchingbuild.py) before the output dir.Because the recorder runs with its working directory at
vcell-native/, this also lets the moving-boundary recording block (which readssrc/test/resources/Solver_Suite_6_2.vcml) execute, so the local build captures config for thevcmlToMovingBoundaryInputpath too.Note
No CI impact (CI uses cibuildwheel/build.py, not this script); this only improves correctness of the documented local macOS native build.
🤖 Generated with Claude Code