Skip to content

Fix sorting of plugins with dependencies#317

Open
domekomi wants to merge 1 commit into
vim-volt:develfrom
domekomi:fix-sortByDepends
Open

Fix sorting of plugins with dependencies#317
domekomi wants to merge 1 commit into
vim-volt:develfrom
domekomi:fix-sortByDepends

Conversation

@domekomi

Copy link
Copy Markdown

Fix a problem that a plugin with deep dependencies is not sorted properly. This PR also add features to detect errors of circular dependencies and missing plugins.

@tyru

tyru commented Mar 25, 2020

Copy link
Copy Markdown
Member

Sorry for late reply.
Could you show me the examples?

  • deep dependencies is not sorted properly
  • circular dependencies
  • missing plugins

@domekomi

Copy link
Copy Markdown
Author

deep dependencies is not sorted properly

If a plugin A depends on B and B doesn't depends on other plugins (A -> B), these plugins are sorted properly. However, if B depends on C (A -> B -> C), not sorted properly.

circular dependencies

e.g. A depends on B and B depends on A (A -> B -> A).

missing plugins

e.g. A depends on B, but B is not found.

@tyru

tyru commented Jan 31, 2022

Copy link
Copy Markdown
Member

Should be related #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants