Skip to content

fix(zkgm): wrong sender field in _timeoutCall#5461

Open
enlightened88 wants to merge 4 commits into
unionlabs:mainfrom
enlightened88:main
Open

fix(zkgm): wrong sender field in _timeoutCall#5461
enlightened88 wants to merge 4 commits into
unionlabs:mainfrom
enlightened88:main

Conversation

@enlightened88
Copy link
Copy Markdown

_timeoutCall was passing call.contractAddress instead of call.sender to encodeCallCalldata. Both _executeCall and _acknowledgeCall use call.sender correctly only the timeout path had the wrong argument.

This causes the inner IBC module to receive a packet with an incorrect sender field on timeout, which can result in a wrong refund address or a stuck packet.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

@enlightened88 is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

@hussein-aitlahcen
Copy link
Copy Markdown
Contributor

hi @enlightened88, very nice finding thanks a lot! would you mind writting a test companion for the fix? if not I'll proceed :).

@enlightened88
Copy link
Copy Markdown
Author

hi @enlightened88, very nice finding thanks a lot! would you mind writting a test companion for the fix? if not I'll proceed :).

hi @hussein-aitlahcen added the test companion in the latest commit!

@hussein-aitlahcen
Copy link
Copy Markdown
Contributor

hi @enlightened88, very nice finding thanks a lot! would you mind writting a test companion for the fix? if not I'll proceed :).

hi @hussein-aitlahcen added the test companion in the latest commit!

I don't see where the test is?

@enlightened88
Copy link
Copy Markdown
Author

hi @enlightened88, very nice finding thanks a lot! would you mind writting a test companion for the fix? if not I'll proceed :).

hi @hussein-aitlahcen added the test companion in the latest commit!

I don't see where the test is?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants