chore(deps): raise conda-petsc floor to >=3.25 (FMG/rotation API consistency)#304
Merged
Conversation
…istency) The conda-petsc environments (default/dev/runtime + mpich/openmpi variants) pinned petsc/petsc4py >=3.21, which resolved to 3.24.x. The custom hierarchical FMG uses a petsc4py 3.25 API (PETSc.KSP.DMActive, custom_mg.py:433), so test_1015/1016/1017 could not run on the conda env (AttributeError) even though they pass on the custom amr build (petsc4py 3.25). This left the conda dev env inconsistent with the code and with the custom build. Raise the conda-petsc floor to >=3.25,<4 (petsc 3.25.3 + petsc4py 3.25.3 numpy-2 builds are on conda-forge). Now petsc and petsc4py agree at 3.25, the DMActive API is present, and the conda dev env matches the custom amr build. Validated on the re-solved dev env (petsc4py 3.25.3, numpy 2.5.0): the full custom-MG / SBR / rotated-free-slip / FMG-lockout suite passes (test_1015/1016/1017/1018/1020 — 29 passed). This also confirms the custom hierarchical FMG is numpy-2 clean (closes the local-validation gap in #303). Underworld development team with AI support from Claude Code
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pixi conda-forge PETSc feature definitions to require PETSc/petsc4py 3.25+, aligning the conda environments with the petsc4py API usage in custom_mg.py (notably PETSc.KSP.DMActive), and preventing conda-env test failures caused by resolving to petsc4py 3.24.x.
Changes:
- Raise
petscminimum version in conda-petsc features from>=3.21,<4to>=3.25,<4. - Raise
petsc4pyminimum version in conda-petsc features from>=3.21,<4to>=3.25,<4. - Apply the same floor consistently across default, mpich, and openmpi conda-petsc feature variants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Thanks @copilot-pull-request-reviewer — the summary is accurate. To add the validation context behind it:
No source changes — config-only floor bump, so the API contract now matches the code. |
… sqlite-3.32.3) The petsc 3.25 bump perturbed the linux-64 conda solve into pulling sqlite-3.32.3, whose bundled libsqlite lacks sqlite3_deserialize, so python's _sqlite3 failed to load (undefined symbol) and any sqlite-importing test module (test_1004) errored at collection. Floor sqlite to >=3.46; re-locked to sqlite 3.51+ on all platforms. Underworld development team with AI support from Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The conda-petsc environments (
default/dev/runtime+ mpich/openmpi) pinned petsc/petsc4py>=3.21, resolving to 3.24.x. The custom hierarchical FMG uses a petsc4py 3.25 API —PETSc.KSP.DMActive(custom_mg.py:433) — sotest_1015/1016/1017fail on the conda env withAttributeError, even though they pass on the customamrbuild (petsc4py 3.25). The condadevenv was inconsistent with both the code and the custom build.Change
Raise the conda-petsc floor to
>=3.25,<4(petsc 3.25.3 + petsc4py 3.25.3 numpy-2 builds are on conda-forge). Now petsc ↔ petsc4py agree at 3.25,DMActiveis present, and the conda dev env matches the custom amr build.Validation
Re-solved
dev(petsc4py 3.25.3, numpy 2.5.0): the custom-MG / SBR / rotated-free-slip / FMG-lockout suite passes —test_1015/1016/1017/1018/1020, 29 passed. This confirms the custom hierarchical FMG is numpy-2 clean and closes the local-validation gap tracked in #303.Follow-on for #247's min-PETSc note: the effective floor for full functionality (custom FMG) is 3.25, not 3.21.
Underworld development team with AI support from Claude Code