some tests/ too-many-statements quality fixes + tidying#4382
Open
clmould wants to merge 9 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4382 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 151 151
Lines 29385 29385
=======================================
Hits 14356 14356
Misses 15029 15029 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1c15027 to
88a0874
Compare
tests/ too-many-stataments quality fixes + tidying
tests/ too-many-stataments quality fixes + tidyingtests/ too-many-statements quality fixes + tidying
…s that are calculated in st_build ,spelling fix
- remove unused vars from being monkeypatched - tidy up monkeypatching to reduce file length
94ff8bd to
75260f9
Compare
…ant_electric_production
remove unnecessarily monkeypatched params shortened input arrays where possible
75260f9 to
68beb10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some more improve-quality-test fixes on tests/ files to remove the 'too-many-statements'
tests for stellerator, dcll, buildings, power, costs_1990
Also general tidying by removing unused monkeypatch params (either not used in the fn being tested, or are directly calculated in the fn being tested and then the output is checked so no need to monkeypatch in the first place)
Checklist
I confirm that I have completed the following checks: