Skip to content

some tests/ too-many-statements quality fixes + tidying#4382

Open
clmould wants to merge 9 commits into
mainfrom
test-quality-fixes
Open

some tests/ too-many-statements quality fixes + tidying#4382
clmould wants to merge 9 commits into
mainfrom
test-quality-fixes

Conversation

@clmould

@clmould clmould commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Description

Some more improve-quality-test fixes on tests/ files to remove the 'too-many-statements'

tests for stellerator, dcll, buildings, power, costs_1990

Also general tidying by removing unused monkeypatch params (either not used in the fn being tested, or are directly calculated in the fn being tested and then the output is checked so no need to monkeypatch in the first place)

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.85%. Comparing base (ddcba6c) to head (68beb10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4382   +/-   ##
=======================================
  Coverage   48.85%   48.85%           
=======================================
  Files         151      151           
  Lines       29385    29385           
=======================================
  Hits        14356    14356           
  Misses      15029    15029           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the test-quality-fixes branch 3 times, most recently from 1c15027 to 88a0874 Compare June 25, 2026 08:56
@clmould clmould changed the title tests/ quality fixes tests/ too-many-stataments quality fixes Jun 25, 2026
@clmould clmould changed the title tests/ too-many-stataments quality fixes tests/ too-many-stataments quality fixes + tidying Jun 25, 2026
@clmould clmould changed the title tests/ too-many-stataments quality fixes + tidying some tests/ too-many-stataments quality fixes + tidying Jun 25, 2026
@clmould clmould changed the title some tests/ too-many-stataments quality fixes + tidying some tests/ too-many-statements quality fixes + tidying Jun 25, 2026
clmould added 3 commits June 25, 2026 17:10
…s that are calculated in st_build ,spelling fix
- remove unused vars from being monkeypatched
- tidy up monkeypatching to reduce file length
@clmould clmould force-pushed the test-quality-fixes branch from 94ff8bd to 75260f9 Compare June 25, 2026 16:10
@clmould clmould marked this pull request as ready for review June 25, 2026 16:24
@clmould clmould requested a review from a team as a code owner June 25, 2026 16:24
@clmould clmould force-pushed the test-quality-fixes branch from 75260f9 to 68beb10 Compare June 26, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants