remove init constants and rename init all module vars#4379
Open
clmould wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4379 +/- ##
==========================================
- Coverage 48.85% 48.84% -0.02%
==========================================
Files 151 151
Lines 29385 29377 -8
==========================================
- Hits 14356 14348 -8
Misses 15029 15029 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
force-pushed
the
4335-remove-init_constants-and-rename-init_all_module_vars
branch
2 times, most recently
from
a7367fd to
6cd2863
Compare
clmould
force-pushed
the
4335-remove-init_constants-and-rename-init_all_module_vars
branch
from
6cd2863 to
bb03ebc
Compare
timothy-nunn
left a comment
timothy-nunn
left a comment
Collaborator
There was a problem hiding this comment.
Will await @chris-ashe review since he suggested removing the densities as inputs and setting them as constant
| "ims": "i_blkt_module_segmentation", | ||
| "i_coolant_pumping": "i_p_coolant_pumping", | ||
| "vfblkt": "f_a_blkt_cooling_channels", | ||
| "dalu": "den_aluminium", |
Collaborator
There was a problem hiding this comment.
Needs to be kept in "dalu": None,
| "dalu": "den_aluminium", | ||
| "dcase": "den_tf_coil_case", | ||
| "dcondins": "den_tf_wp_turn_insulation", | ||
| "dcopper": "den_copper", |
Collaborator
There was a problem hiding this comment.
Needs to be kept in "dcopper": None,
Collaborator
There was a problem hiding this comment.
Please mark den_copper and den_aluminium as obsolete too (e.g. "den_aluminium": None)
chris-ashe
requested changes
Jun 26, 2026
| """Average number of days in a year""" | ||
|
|
||
| ACCELERATION_GRAVITY = 9.81 | ||
| """Acceleration due to gravity [m/s2]""" |
Collaborator
There was a problem hiding this comment.
Suggested change
| """Acceleration due to gravity [m/s2]""" | |
| """Acceleration due to gravity on Earth's surface [m/s²]""" |
Just adding this in here as I saw it below and it annoyed me
clmould
force-pushed
the
4335-remove-init_constants-and-rename-init_all_module_vars
branch
from
2960e07 to
af83215
Compare
clmould
force-pushed
the
4335-remove-init_constants-and-rename-init_all_module_vars
branch
2 times, most recently
from
95a4b72 to
edaf542
Compare
clmould
force-pushed
the
4335-remove-init_constants-and-rename-init_all_module_vars
branch
from
edaf542 to
41c9c37
Compare
chris-ashe
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4335
Checklist
I confirm that I have completed the following checks: