Skip to content

Add PFConductorModel enum and refactor related code for clarity#4372

Merged
timothy-nunn merged 1 commit into
mainfrom
add_pf_conductor_enum
Jun 25, 2026
Merged

Add PFConductorModel enum and refactor related code for clarity#4372
timothy-nunn merged 1 commit into
mainfrom
add_pf_conductor_enum

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (aada716) to head (674ce07).

Files with missing lines Patch % Lines
process/models/pfcoil.py 63.63% 4 Missing ⚠️
process/models/tfcoil/base.py 33.33% 2 Missing ⚠️
process/models/power.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4372      +/-   ##
==========================================
+ Coverage   48.83%   48.85%   +0.01%     
==========================================
  Files         151      151              
  Lines       29376    29385       +9     
==========================================
+ Hits        14347    14356       +9     
  Misses      15029    15029              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Jun 23, 2026
@chris-ashe chris-ashe force-pushed the add_pf_conductor_enum branch from 6e3de4e to 674ce07 Compare June 25, 2026 10:45
@timothy-nunn timothy-nunn merged commit ddcba6c into main Jun 25, 2026
19 of 22 checks passed
@timothy-nunn timothy-nunn deleted the add_pf_conductor_enum branch June 25, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants