Refactor TF coil models to remove internal cross-section parameters a…#4371
Open
chris-ashe wants to merge 1 commit into
Open
Refactor TF coil models to remove internal cross-section parameters a…#4371chris-ashe wants to merge 1 commit into
chris-ashe wants to merge 1 commit into
Conversation
…nd replace with area of CS poloidal cross-section
6 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4371 +/- ##
=======================================
Coverage 48.77% 48.78%
=======================================
Files 151 151
Lines 29390 29387 -3
=======================================
Hits 14336 14336
+ Misses 15054 15051 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the Central Solenoid (CS) poloidal cross-sectional area is handled in the TF coil stress calculations. Instead of calculating the CS area inside the
stressclfunction using several geometric parameters, the area is now passed directly as a parameter (a_cs_poloidal). This change simplifies the interface and removes the need for the previously used parameters. The refactor is applied across the main code and the unit tests.Refactoring of CS poloidal area handling:
The
stressclfunction inprocess/models/tfcoil/base.pynow takesa_cs_poloidalas a direct argument and no longer requiresz_tf_inside_halforf_z_cs_tf_internal. The area calculation inside the function has been removed, and all references to the removed parameters are deleted.All calls to
stressclinprocess/models/tfcoil/resistive.pyandprocess/models/tfcoil/superconducting.pyare updated to passa_cs_poloidalinstead of the removed parameters.Test updates:
The
StressclParamtest data structure intests/unit/models/tfcoil/test_tfcoil.pyis updated to removez_tf_inside_halfandf_z_cs_tf_internal, and to adda_cs_poloidal. All test cases and calls tostressclare updated accordingly.Description
Checklist
I confirm that I have completed the following checks: