Add CS Tresca and 2D contour plots#4325
Open
chris-ashe wants to merge 21 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
- Coverage 48.77% 48.53% -0.25%
==========================================
Files 151 151
Lines 29390 29643 +253
==========================================
+ Hits 14336 14386 +50
- Misses 15054 15257 +203 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…e stress yield locus plotting
…ofiles for radial and hoop stress
… peak axial stress section
…Solenoid stress variables across multiple files
… in Central Solenoid constraints
…Solenoid stress variables across multiple data files
…iveMethodType check for beam parameters
…s and updating formula
…ions for clarity and simplification
…profile and enhancing radial stress profile visualization
…yield locus function
f85f77d to
f4de71f
Compare
…ial in input data files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the central solenoid (CS) stress modeling, variable naming consistency, and documentation. The main changes include refactoring variable names for clarity, adding new stress calculation methods (Tresca and von Mises), expanding the CS stress data model, and updating documentation to match the new, more general approach to CS stress calculations.
Central Solenoid Stress Modeling and Calculations:
materials.py, enabling more comprehensive CS stress analysis.PFCoilDataclass to include vertical profiles of axial stress, radial stress (peak and inner), and von Mises stress for the central solenoid.i_cs_stressswitch, reflecting a shift to always considering both hoop and axial stresses.Variable Naming Consistency and Refactoring:
alstrohtostress_cs_steel_maxthroughout the codebase, input files, and documentation for clarity and consistency.Documentation Updates:
i_cs_stressswitch and clarified the use of Tresca and von Mises criteria.These changes modernize the CS stress model, improve clarity for users and developers, and lay the groundwork for more advanced stress analysis and postprocessing.
Checklist
I confirm that I have completed the following checks: