logger: bound uuid pointer to include the entry size#10921
Open
lgirdwood wants to merge 1 commit into
Open
Conversation
The uuid pointer bounds check did not reserve space for the full entry, so a pointer near the end of the region could read an entry straddling the buffer end. Require a whole entry to fit before dereferencing. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Tightens UUID-pointer bounds validation in sof-logger so the logger can’t read a struct sof_uuid_entry that straddles the end of the UUID region when parsing crafted .ldc dictionaries.
Changes:
- Updates the upper-bound check to account for
sizeof(struct sof_uuid_entry)(not just the pointer position). - Adds an explanatory comment clarifying the rationale and failure mode.
Comment on lines
134
to
+136
| if (uid_ptr < uids_dict->base_address || | ||
| uid_ptr >= uids_dict->base_address + uids_dict->data_length) { | ||
| uid_ptr + sizeof(struct sof_uuid_entry) > | ||
| uids_dict->base_address + uids_dict->data_length) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UUID-pointer bounds check in sof-logger only required the pointer to be
below the end of the uids region, not that a whole
struct sof_uuid_entryfits. A crafted .ldc dictionary with a UUID pointer near the end of the region
could make the logger read an entry straddling the buffer end. Include the
entry size in the upper-bound check.