ipc: use-after-free fixes#10917
Open
abonislawski wants to merge 2 commits into
Open
Conversation
When ipc4_chain_dma_state() fails for a freshly created chain DMA unlink and free the ipc_comp_dev as well, not just the comp_dev Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
ipc_comp_free() freed a component that a completed pipeline still referenced via source_comp/sink_comp/sched_comp, so a later SET_PIPELINE_STATE dereferenced the freed comp_dev. Clear those references on free and bail out of pipeline_get_host_dev() when an endpoint is gone. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
bardliao,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko,
plbossart and
tmleman
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes IPC4 pipeline-related use-after-free scenarios by clearing stale component pointers and freeing intermediate structures during error paths.
Changes:
- Add a NULL-guard in
pipeline_get_host_dev()to avoid dereferencing freed pipeline comps. - On chain-DMA setup failure, remove and free
cdma_complist nodes to prevent later UAF/leaks. - When freeing a component, clear any pipeline
source_comp/sink_comp/sched_compraw pointers referencing it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ipc/ipc4/handler-user.c | Adds pipeline component NULL-guard and frees/removes chain-DMA list nodes on error. |
| src/ipc/ipc-helper.c | Clears raw component pointers stored in pipeline structs when components are freed. |
tmleman
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.