Skip to content

topology2: Update memory requirements to what the our current FW expects #10903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarha wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −33
Open

topology2: Update memory requirements to what the our current FW expects #10903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cfd549
topology2: Increase widget default value for stack from 4k to 8k
May 7, 2026
235755f
topology2: Remove lifetime and shared -bytes_requirement widget attri…
Jun 2, 2026
c9b21d6
topology2: cavs-nocodec.conf: Fine tune SRC DP memory requirements
May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tools/topology/topology2/cavs-nocodec.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,9 +698,9 @@ IncludeByKey.PASSTHROUGH {
IncludeByKey.SRC_DOMAIN {
"DP" {
core_id $DP_SRC_CORE_ID
domain_id 123
stack_bytes_requirement 4096
heap_bytes_requirement 8192
domain_id 0
stack_bytes_requirement 2048
heap_bytes_requirement "$[(24 * 1024)]"
Comment on lines +701 to +703

@jsarha jsarha Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topology parser evaluates expressions enclosed in $[] .

}
}
}
Expand Down Expand Up @@ -1382,9 +1382,9 @@ IncludeByKey.PASSTHROUGH {
IncludeByKey.SRC_DOMAIN {
"DP" {
core_id $DP_SRC_CORE_ID
domain_id 123
stack_bytes_requirement 4096
heap_bytes_requirement 8192
domain_id 0
stack_bytes_requirement 2048
heap_bytes_requirement "$[(24 * 1024)]"
}
}

Expand Down
4 changes: 1 addition & 3 deletions tools/topology/topology2/include/common/tokens.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ Object.Base.VendorToken {
scheduler_domain 418
domain_id 419
stack_bytes_requirement 420
interim_heap_bytes_requirement 421
lifetime_heap_bytes_requirement 422
shared_bytes_requirement 423
heap_bytes_requirement 421
}
Comment on lines 28 to 32

@jsarha jsarha Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes mostly revert the changes made in 83390bd and there has not been any SOF release in between those. These extra attributes are not needed AFAICT so I do not think we should have them.


"2" {
Expand Down
27 changes: 3 additions & 24 deletions tools/topology/topology2/include/components/widget-common.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,33 +149,12 @@ DefineAttribute."stack_bytes_requirement" {
token_ref "comp.word"
}

## Interim Heap size requirement in bytes for this component.
## Used for resources that may change in size or be freed during the lifetime of the component.
## In practice this means anything allocated outside module's init() call-back.
DefineAttribute."interim_heap_bytes_requirement" {
# Token set reference name and type
token_ref "comp.word"
}

## Lifetime heap memory allocation requirement in bytes for this component.
## This token's value indicates the amount of allocated memory needed at component init phase
## and used over the lifetime of the component until the component is destroyed.
## In practice this means anything allocated in init() call-back.
DefineAttribute."lifetime_heap_bytes_requirement" {
# Token set reference name and type
token_ref "comp.word"
}

## Shared memory allocation requirement in bytes for this component.
## This token's value indicates the amount of shared memory the component may need to allocated.
## Shared memory may be shared to other components.
DefineAttribute."shared_bytes_requirement" {
## Heap size requirement in bytes for this component.
DefineAttribute."heap_bytes_requirement" {
# Token set reference name and type
token_ref "comp.word"
}
Comment on lines +152 to 156

@jsarha jsarha Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FW will decide the division between different memory types. All that is needed is the amount of memory required. There is no need to add any more information here.


# These default values are here until we have measured module specific numbers
stack_bytes_requirement 8192
interim_heap_bytes_requirement 4096
lifetime_heap_bytes_requirement 16384
shared_bytes_requirement 4096
heap_bytes_requirement 24576

@jsarha jsarha Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are repeating yourself

Loading