Refactor password management for externally managed users#594
Merged
Conversation
- Update password reset logic to handle users managed by courses.mooc.fi and those without a delegation ID. - Enhance error handling and logging for authentication failures related to external management. - Normalize password input to ensure consistent authentication across different Unicode forms. - Add validations for courses.mooc.fi user ID to prevent misconfigurations.
houndci-bot
reviewed
Jun 11, 2026
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Unable to find gem rubocop-rails_config; is the gem installed? Gem::MissingSp...
Unable to find gem rubocop-rails_config; is the gem installed? Gem::MissingSpecError /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:237:in `rescue in gem_config_path' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:227:in `gem_config_path' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:55:in `block (2 levels) in resolve_inheritance_from_gems' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:53:in `reverse_each' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:53:in `block in resolve_inheritance_from_gems' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:46:in `each_pair' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:46:in `resolve_inheritance_from_gems' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader.rb:49:in `load_file' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader.rb:104:in `configuration_from_file' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_store.rb:58:in `for_dir' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_store.rb:37:in `for_pwd' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/cli.rb:128:in `apply_default_formatter' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/cli.rb:40:in `run' /home/linters/.bundle/gems/rubocop-1.5.2/exe/rubocop:13:in `block in ' /usr/local/lib/ruby/2.6.0/benchmark.rb:308:in `realtime' /home/linters/.bundle/gems/rubocop-1.5.2/exe/rubocop:12:in `' /home/linters/.bundle/bin/rubocop:23:in `load' /home/linters/.bundle/bin/rubocop:23:in `' /usr/local/lib/ruby/2.6.0/bundler/cli/exec.rb:74:in `load' /usr/local/lib/ruby/2.6.0/bundler/cli/exec.rb:74:in `kernel_load' /usr/local/lib/ruby/2.6.0/bundler/cli/exec.rb:28:in `run' /usr/local/lib/ruby/2.6.0/bundler/cli.rb:463:in `exec' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor.rb:387:in `dispatch' /usr/local/lib/ruby/2.6.0/bundler/cli.rb:27:in `dispatch' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/base.rb:466:in `start' /usr/local/lib/ruby/2.6.0/bundler/cli.rb:18:in `start' /usr/local/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/exe/bundle:30:in `block in ' /usr/local/lib/ruby/2.6.0/bundler/friendly_errors.rb:124:in `with_friendly_errors' /usr/local/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/exe/bundle:22:in `' /usr/local/bin/bundle:23:in `load' /usr/local/bin/bundle:23:in `'
HTTP Basic Auth credentials are Base64-decoded into ASCII-8BIT strings, and unicode_normalize raises Encoding::CompatibilityError on any ASCII-8BIT string regardless of its contents. Reinterpret the bytes as UTF-8 before normalizing, and leave the password untouched when the bytes are not valid UTF-8.
houndci-bot
reviewed
Jun 16, 2026
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Unable to find gem rubocop-rails_config; is the gem installed? Gem::MissingSp...
Unable to find gem rubocop-rails_config; is the gem installed? Gem::MissingSpecError /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:237:in `rescue in gem_config_path' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:227:in `gem_config_path' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:55:in `block (2 levels) in resolve_inheritance_from_gems' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:53:in `reverse_each' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:53:in `block in resolve_inheritance_from_gems' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:46:in `each_pair' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader_resolver.rb:46:in `resolve_inheritance_from_gems' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader.rb:49:in `load_file' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_loader.rb:104:in `configuration_from_file' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_store.rb:58:in `for_dir' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/config_store.rb:37:in `for_pwd' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/cli.rb:128:in `apply_default_formatter' /home/linters/.bundle/gems/rubocop-1.5.2/lib/rubocop/cli.rb:40:in `run' /home/linters/.bundle/gems/rubocop-1.5.2/exe/rubocop:13:in `block in ' /usr/local/lib/ruby/2.6.0/benchmark.rb:308:in `realtime' /home/linters/.bundle/gems/rubocop-1.5.2/exe/rubocop:12:in `' /home/linters/.bundle/bin/rubocop:23:in `load' /home/linters/.bundle/bin/rubocop:23:in `' /usr/local/lib/ruby/2.6.0/bundler/cli/exec.rb:74:in `load' /usr/local/lib/ruby/2.6.0/bundler/cli/exec.rb:74:in `kernel_load' /usr/local/lib/ruby/2.6.0/bundler/cli/exec.rb:28:in `run' /usr/local/lib/ruby/2.6.0/bundler/cli.rb:463:in `exec' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor.rb:387:in `dispatch' /usr/local/lib/ruby/2.6.0/bundler/cli.rb:27:in `dispatch' /usr/local/lib/ruby/2.6.0/bundler/vendor/thor/lib/thor/base.rb:466:in `start' /usr/local/lib/ruby/2.6.0/bundler/cli.rb:18:in `start' /usr/local/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/exe/bundle:30:in `block in ' /usr/local/lib/ruby/2.6.0/bundler/friendly_errors.rb:124:in `with_friendly_errors' /usr/local/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/exe/bundle:22:in `' /usr/local/bin/bundle:23:in `load' /usr/local/bin/bundle:23:in `'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.