v2: terminalize (v2-native tree walker) so terminal() needs no v1#28
Merged
Conversation
Add Terminalwire::V2::Server.terminalize — like dualize, but includes the v2-native Terminalwire::V2::Server::Thor (no v1 `super`) across the Thor tree. Point Terminalwire::V2::Rails.terminal at it, so a v2-only app can load ONLY the v2 gem (no v1 server coexisting). dualize stays for the transitional both-protocols path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Terminalwire::V2::Server.terminalize(v2-native analog ofdualize— includesTerminalwire::V2::Server::Thor, no v1super) and pointsterminal()at it, so a v2-only app loads only the v2 gem with no v1 server coexisting.dualize/dual_terminalunchanged. Gem specs 90/0.