v2/rails: add Terminalwire::V2::Rails.terminal (v2-default version endpoint)#26
Merged
Conversation
…ndpoint The v2-only mount. Returns a VersionEndpoint that routes a WebSocket upgrade by the advertised version subprotocol and defaults to v2 — the same Rack-endpoint shape as dual_terminal's Dispatcher (which Rails 'match to:' hands off correctly in prod), minus the v1 branch. A bare Server::Rack handed to 'match to:' drops streaming output in production; the endpoint is what's needed. It's also the forward-compatible seam: a future v3 registers another handler without changing the app's route. Additive — dual_terminal is unchanged. Specs: VersionEndpoint dispatch + .terminal (6 examples); full v2 suite 90/0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2-only Rails mount. Returns a
VersionEndpointthat routes a WebSocket upgrade by the advertised version subprotocol and defaults to v2 — the same Rack-endpoint shape asdual_terminal'sDispatcher(which Railsmatch to:hands off correctly in prod), minus the v1 branch. (A bareServer::Rackhanded tomatch to:drops streaming output in production — that's what the endpoint avoids.) It's also the forward-compatible seam: a future v3 registers another handler without changing the app's route.Additive —
dual_terminaluntouched, so terminalwire.com is unaffected. Specs: VersionEndpoint dispatch +.terminal(6 examples); full v2 suite 90/0.