test: mechanical security floor for the server library#3
Merged
Conversation
…ser / atom creation) The server runs untrusted input — a hostile client sends arbitrary frames and the CLI runs client-controlled argv. A static test asserts lib/ never contains the primitives that would let that punch through: Code.eval/EEx, System.cmd/:os.cmd/ Port.open, binary_to_term, or String.to_atom/binary_to_atom/list_to_atom (atom-table exhaustion). Passes today; fails the build if one ever creeps in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a static guard test asserting the library never reaches for arbitrary code execution (Code.eval/EEx), shell-out (System.cmd/:os.cmd/Port.open), unsafe deserialization (binary_to_term), or untrusted-string→atom conversion (String.to_atom/binary_to_atom/list_to_atom — atom-table exhaustion). The server runs untrusted client input, so none of these may be one grep away. Backs the manual security audit; passes today and fails the build if a dangerous primitive is ever added.