feat(validator): add failing test for Validator::getErrorMessage#2195
Closed
NeoIsRecursive wants to merge 1 commit into
Closed
feat(validator): add failing test for Validator::getErrorMessage#2195NeoIsRecursive wants to merge 1 commit into
Validator::getErrorMessage#2195NeoIsRecursive wants to merge 1 commit into
Conversation
translation keys
Member
No it's not, it's used internally and useful for custom rules for which the translator isn't needed, we should document that Should we close this PR in favor of Màrk's? |
Contributor
Author
Ah, good! (mainly wanted to check before doing work).
Yes! His contains fixes and everything, much better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a failing test for the validation error message issue mentioned in #2194, and since I didnt find a more generic test for the translation keys, I added one for that too.
Can add a fix in here too, but im wondering if the
HasErrorMessageinterface is to be deprecated since it is not mentioned in the documentation?Cheers! 😄