Remove Nextcloud auto-symlink + drop unused Remote-Groups header#4
Merged
Conversation
The storage-change hook symlinked the whole /data/nextcloud tree into the library, which dragged in non-music content (course videos, trashbin, versions, appdata, tmp) and buried real music under [Unknown Album] entries. Drop the auto-link for now; storage-change just inits and chowns the app storage. Library sources can be set up deliberately later.
Navidrome's ExtAuth path only reads the user header (ND_EXTAUTH_USERHEADER); it never consumes groups and has no group->admin mapping, so forwarding Remote-Groups did nothing. Remove the header and its auth_request_set var from both the session and basic auth-request configs.
cyberb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups now that the library-management story is clearer.
1. Remove Nextcloud auto-symlink
The
storage-changehook symlinked the entire/data/nextcloudtree into the library (/data/navidrome/nextcloud -> /data/nextcloud), which dragged in non-music content — course videos,files_trashbin(deleted files),files_versions,appdata_*,tmp— burying real music under[Unknown Album]entries (observed on boris: 877 tracks scanned, only ~351 real music, 164 from trashbin). Drop the auto-link;StorageChange()now just inits and chowns storage. An admin can add a scoped library (e.g./data/nextcloud/<user>/files/Music) via Settings → Libraries in the web UI instead (multi-library since navidrome v0.58.0; paths must be absolute + readable by the process).linkNextcloud()and its call inStorageChange.test_nextcloud_link_forcedintegration test.2. Drop unused Remote-Groups header
Navidrome's ExtAuth path only reads the user header (
ND_EXTAUTH_USERHEADER); it never consumes groups and has no group→admin mapping (admin = first provisioned user). ForwardingRemote-Groupsdid nothing, so remove the header and itsauth_request_setvar from both the session and basic auth-request configs.CLI
go vet+go buildclean.