ci: add benchmark comparison job for PR regression detection#21082
Draft
lvalerom wants to merge 10 commits into
Draft
ci: add benchmark comparison job for PR regression detection#21082lvalerom wants to merge 10 commits into
lvalerom wants to merge 10 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
🚀 Build Images ReadyImages are ready for commit b3bf259. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-161-gb3bf259bb5 |
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Benchmark Comparison |
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a CI job that automatically compares Go benchmark results between a PR and its base branch. When a PR touches packages that contain benchmarks, the job runs them on both refs using git worktrees, compares with
benchstat, and posts results as a PR comment.scripts/bench-compare.sh— local script that detects changed packages, runs benchmarks on both refs, compares with benchstatgo-bench-comparejob inunit-tests.yaml— CI wrapper that calls the script and posts resultsThe job is non-blocking (
continue-on-error: true) and only runs on PRs.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Tested the script locally by introducing an artificial regression (adding a mutex to
ValueStream.Push) and runningscripts/bench-compare.sh. The script correctly detected the regression withbenchstatshowing+78.82% (p=0.008)onBenchmarkValueStreamWrite.