Skip to content

refac(cdn): Migrate to new SDK structure#1421

Merged
Fyusel merged 1 commit into
mainfrom
migrate-cdn-to-new-sdk-struct
Jun 8, 2026
Merged

refac(cdn): Migrate to new SDK structure#1421
Fyusel merged 1 commit into
mainfrom
migrate-cdn-to-new-sdk-struct

Conversation

@Fyusel
Copy link
Copy Markdown
Contributor

@Fyusel Fyusel commented May 27, 2026

STACKITCLI-356

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner May 27, 2026 10:19
@Fyusel Fyusel force-pushed the migrate-cdn-to-new-sdk-struct branch from 9711742 to c5bf0f4 Compare May 27, 2026 10:56
Comment thread docs/stackit_beta_cdn_distribution_create.md Outdated
Comment thread internal/pkg/services/cdn/client/client.go
@Fyusel Fyusel force-pushed the migrate-cdn-to-new-sdk-struct branch 2 times, most recently from d853b5c to 9b9aec8 Compare June 3, 2026 12:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create 82.61% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete 27.59% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe 88.89% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list 81.16% (+0.56%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update 85.07% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/utils 58.04% (-3.29%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create.go 82.61% (ø) 115 95 20
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete/delete.go 27.59% (ø) 29 8 21
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe/describe.go 88.89% (ø) 117 104 13
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list.go 81.16% (+0.56%) 69 (+2) 56 (+2) 13 👍
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update.go 85.07% (ø) 134 114 20
github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/utils/utils.go 57.14% (-4.83%) 77 (+6) 44 33 (+6) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update_test.go

@Fyusel Fyusel force-pushed the migrate-cdn-to-new-sdk-struct branch from 9b9aec8 to 7ba6da9 Compare June 8, 2026 06:24
STACKITCLI-356

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel Fyusel force-pushed the migrate-cdn-to-new-sdk-struct branch from 7ba6da9 to 8797ae0 Compare June 8, 2026 06:25
@Fyusel Fyusel merged commit 1fb803c into main Jun 8, 2026
3 checks passed
@Fyusel Fyusel deleted the migrate-cdn-to-new-sdk-struct branch June 8, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants