Skip to content

add us2 region for NinjaOne#58

Merged
clarkd merged 3 commits into
mainfrom
work/dw/PLUG-4644-ninjaone-us2-region
Jun 8, 2026
Merged

add us2 region for NinjaOne#58
clarkd merged 3 commits into
mainfrom
work/dw/PLUG-4644-ninjaone-us2-region

Conversation

@Deenk
Copy link
Copy Markdown
Contributor

@Deenk Deenk commented Jun 5, 2026

📋 Summary

Adds the US2 region as a selectable option for the NinjaOne plugin. A customer whose NinjaOne instance is hosted in the US2 region was unable to connect via SquaredUp, as only US, EU, Canada, and OC regions were previously available. This PR adds the US2 API base URL (https://us2-api.ninjarmm.com) to the region selector.


🔗 Related issue(s)

  • Relates to PLUG-4644

🧩 Plugin details

  • Plugin name: NinjaOne
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

@Deenk Deenk added the bug Something isn't working label Jun 5, 2026
@Deenk Deenk changed the title add us2 region add us2 region for NinjaOne Jun 5, 2026
@Deenk Deenk marked this pull request as ready for review June 5, 2026 15:42
@Deenk Deenk requested a review from a team June 5, 2026 15:42
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — small, mechanical config change adding US2 region with appropriate version bump.

Extended reasoning...

Overview

This PR adds the US2 region to the NinjaOne plugin's region selector in plugins/NinjaOne/v1/ui.json and bumps the plugin version in metadata.json from 1.1.11 to 1.1.12. The change consists of inserting one new option (https://api.us2.ninjarmm.com / US2) into an existing radio field, alongside the required version increment.

Security risks

None. The change adds a static URL constant to a radio dropdown — no auth code, no credential handling, no parsing logic, no user input processing. The base URL is still consumed by the existing OAuth2 clientCredentials flow defined in metadata.json, which is unchanged.

Level of scrutiny

Low. This is exactly the kind of mechanical, low-risk config change that fits the approval criteria — a single new entry in a list of allowed region values, following the established pattern of the other four entries. Validation passed in CI and the PR is correctly version-bumped per repo guidelines.

Other factors

A bug-hunter Nit was raised about docs/README.md line 24 still enumerating only the original four regions; this is a real but cosmetic inconsistency (the dropdown is authoritative, so functionality is unaffected) and is captured in an inline comment for the author to address. It is not severe enough to block approval. An earlier commit (02fec4f) on this branch already corrected the URL from the PR description's us2-api.ninjarmm.com to the correct api.us2.ninjarmm.com, so the URL form is current.

Comment thread plugins/NinjaOne/v1/ui.json
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 8, 2026

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/NinjaOne/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

ninja-one
{
  "valid": true,
  "pluginName": "ninja-one",
  "pluginType": "cloud",
  "summary": {
    "Data Streams": 37,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

@clarkd clarkd merged commit fdc413f into main Jun 8, 2026
1 check passed
@clarkd clarkd deleted the work/dw/PLUG-4644-ninjaone-us2-region branch June 8, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants