Remove JS based splat file format decoders#374
Open
mrxz wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the loading and decoding of splat formats has been moved to the
spark-lib/spark-rsprojects, the JS based decoders should be removed. Maintaining two implementations for each format is impractical and having it in the code base can cause confusion, not to mention bloats the bundle (#321).The only component still depending on these JS based decoders was the
transcodeSpzmethod (and correspondingcompress-to-spz.jsscript), which has been rewritten to delegate tospark-rsas well. This has the added benefit that it now also supports all input formats, instead of being limited to a subset.Warning
There is one clear behavioural change, the old JS based spz encoder produced SPZv3, whereas
spark-rsgenerates SPZv2.Ultimately the bundle size savings (for #321) is limited, though this does open up the possibility of eliminating the
fflatedependency. Currently that is still needed for proper file type detection. But since that is also duplicated between JS and Rust, it might be possible to unify it as well.