chore(rust): fix clippy warnings in splat sorting functions#370
chore(rust): fix clippy warnings in splat sorting functions#370mmjinglin163 wants to merge 1 commit into
Conversation
|
Thanks for the PR, the changes look good for the most part. Personally I think the elimination of the let binding for Though if we're going to use clippy, I'd rather see it integrated and enforced (similar to TS linting through biome). Otherwise we'd end up with having to play catch-up with PRs every time changes to the Rust code introduces new linter warnings. @asundqui any preference in this matter? |
|
Thanks for the review! Regarding active_splats : I totally agree that readability should come first for maintainers. If you prefer the let binding, I can easily revert that part and add #[allow(clippy::let_and_return)] above it to keep Clippy happy without sacrificing readability. Just let me know if you want me to do that! Regarding the Clippy integration: I 100% agree. Relying on manual checks is prone to regressions. We should definitely enforce it in CI just like Biome for TS. My preference would be to:
|
chore(rust): fix clippy warnings in splat sorting functions