Fix exports disappearing

[huseeiin]

fix #2100

Please check if your PR fulfills the following requirements:

• Addresses an existing open issue: fixes #000
• Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

[changeset-bot]

🦋 Changeset detected

Latest commit: c3b5d32

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	c3b5d32
🔍 Latest deploy log	https://app.netlify.com/projects/solid-start-landing-page/deploys/69b50f3c69f1c80008b72750
😎 Deploy Preview	https://deploy-preview-2104--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2104

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2104

commit: 5541b4e

[atilafassina]

this is one of the regressions from the Vinxi migration we always set on a fence about fixing.

While the disappearing export is an issue, a worse one would be to exposing server-only code accidentally to the client-bundle by adding an export in a file that is originally intended only for the server.

The workaround would be to export that variable somewhere else and have the API Route only consuming it instead.

---

Let's revisit this issue once #2070 and perhaps #2094 as well.

cc @lxsmnsyc

[lxsmnsyc]

For the sake of loader modules this might be intentional. We probably would just recommend restructuring the module such that the said target exports is imported from a separate module, as mentioned by @atilafassina

I'm inclined on a "wontfix"

[brenelz]

So do we just close this pr?