remove avoid_unnecessary_type_casts

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.0.0
+
+- feat!: migrate to analyzer_server_plugin
+- refactor: replace `avoid_unnecessary_type_casts` rule with dart analyzer's `unnecessary_cast`
+
 ## 0.3.3
 
 - Fix pub.dev analysis issue

lib/analysis_options.yaml

@@ -3,21 +3,21 @@ analyzer:
     - custom_lint
   exclude:
     # General generated files
-    - '**/*.g.dart'
-    - '**/*.gr.dart'
+    - "**/*.g.dart"
+    - "**/*.gr.dart"
 
     # Flutter
-    - 'lib/generated_plugin_registrant.dart'
+    - "lib/generated_plugin_registrant.dart"
 
     # mockito
-    - '*.mocks.dart'
-    - '**/*.mocks.dart'
+    - "*.mocks.dart"
+    - "**/*.mocks.dart"
 
     # freezed
-    - '**/*.freezed.dart'
+    - "**/*.freezed.dart"
 
     # protobuf
-    - '**/*.pb.dart'
+    - "**/*.pb.dart"
 
     # test_coverage
     - test/.test_coverage.dart
@@ -33,6 +33,7 @@ analyzer:
     missing_required_param: error
     missing_return: error
     parameter_assignments: error
+    unnecessary_cast: warning
 
 custom_lint:
   rules:
@@ -48,7 +49,6 @@ custom_lint:
     - avoid_unnecessary_return_variable
     - avoid_unnecessary_setstate
     - avoid_unnecessary_type_assertions
-    - avoid_unnecessary_type_casts
     - avoid_unrelated_type_assertions
     - avoid_unused_parameters
     - avoid_debug_print_in_release
@@ -87,7 +87,7 @@ custom_lint:
     - number_of_parameters:
       max_parameters: 7
       exclude:
-        - method_name: copyWith 
+        - method_name: copyWith
 
     - prefer_conditional_expressions:
       ignore_nested: true

lib/main.dart

@@ -35,6 +35,7 @@ class SolidLintsPlugin extends Plugin {
     final avoidUnnecessaryTypeAssertionsRule =
         AvoidUnnecessaryTypeAssertionsRule();
     final doubleLiteralFormatRule = DoubleLiteralFormatRule();
+
     final lintRules = [
       AvoidFinalWithGetterRule(),
       AvoidGlobalStateRule(),

lib/src/utils/typecast_utils.dart

@@ -6,7 +6,6 @@ import 'package:collection/collection.dart';
 
 // TODO: consider to move here common functions for rules
 // avoid_unnecessary_type_assertions
-// avoid_unnecessary_type_casts (after implementation)
 // avoid_unrelated_type_assertions (after implementation)
 
 /// A class for representing arguments for types checking methods
@@ -66,9 +65,10 @@ class TypeCast {
       return false;
     }
 
-    if (this case TypeCast(source: final objectType, target: final castedType)
-        when objectType is ParameterizedType &&
-            castedType is ParameterizedType) {
+    if (this case TypeCast(
+      source: final objectType,
+      target: final castedType,
+    ) when objectType is ParameterizedType && castedType is ParameterizedType) {
       if (objectType.typeArguments.length != castedType.typeArguments.length) {
         return false;
       }

lint_test/analysis_options.yaml

@@ -30,7 +30,6 @@ custom_lint:
     - avoid_unnecessary_setstate
     - double_literal_format
     - avoid_unnecessary_type_assertions
-    - avoid_unnecessary_type_casts
     - avoid_unrelated_type_assertions
     - avoid_unused_parameters:
       exclude: