Skip to content

Calculate S-DAC carbon revenue (BICYCLE); Add SAM-EM S-DAC support [v3.15]#172

Closed
softwareengineerprogrammer wants to merge 19 commits into
mainfrom
s-dac-carbon-revenue-4
Closed

Calculate S-DAC carbon revenue (BICYCLE); Add SAM-EM S-DAC support [v3.15]#172
softwareengineerprogrammer wants to merge 19 commits into
mainfrom
s-dac-carbon-revenue-4

Conversation

@softwareengineerprogrammer

@softwareengineerprogrammer softwareengineerprogrammer commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Description

  1. Addresses S-DAC does not calculate carbon revenue NatLabRockies/GEOPHIRES-X#341 (BICYCLE economic model)
  2. Adds S-DAC support for SAM Economic Models - revenue modeled via Other PBI Income.

TODO

  1. 🚧 SAM-EM support: e30dc21
    1. S-DAC-GT-2 example name/description finalization
    2. Account for electricity from grid
  2. Documentation
  3. Automatically set Do S-DAC-GT Calculations

Testing & Verification

  1. Unit tests added:
    1. S-DAC-GT-2
  2. Unit tests updated:
    1. S-DAC-GT
    2. test_parse_sdacgt_profile
  3. Manual testing:
    1. 🚧 Web interface:
      1. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT
      2. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT-2

Change Checklist:

Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).

Before merging:

  1. I certify that I am a human and I have manually verified the correctness of the changes in this PR.
  2. Add a CHANGELOG entry (example). RST Template:
3.15: `TITLE <https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER>`__ | `release <https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.15.P>`__

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/v3.15.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
3.15: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.15.P)

Self-reviewed in #172

@softwareengineerprogrammer softwareengineerprogrammer added bug Something isn't working enhancement New feature or request labels Jun 19, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title [WIP] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.15] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.15] Jun 19, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.15] Calculate S-DAC carbon revenue [BICYCLE + SAM-EM] [v3.15] Jun 19, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title Calculate S-DAC carbon revenue [BICYCLE + SAM-EM] [v3.15] Calculate S-DAC carbon revenue (BICYCLE), add SAM-EM S-DAC support [v3.15] Jun 19, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title Calculate S-DAC carbon revenue (BICYCLE), add SAM-EM S-DAC support [v3.15] Calculate S-DAC carbon revenue (BICYCLE); Add SAM-EM S-DAC support [v3.15] Jun 19, 2026
@softwareengineerprogrammer

Copy link
Copy Markdown
Owner Author

Abandoning SAM-EM support and created tracking issue: NatLabRockies#511

Moved BICYCLE support to #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant