Emit empty payload for RPC protocol event encoding#1245
Merged
Conversation
Add emitEmptyPayload flag so RPC protocols (awsJson, rpcv2-cbor) serialize an empty body and set content-type when there are no payload members, while REST protocols continue to omit both.
Add forInputStream/forOutputStream overloads without emitEmptyPayload parameter, defaulting to false (REST behavior) for backwards compatibility.
mtdowling
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
RPC protocols (awsJson, rpcv2-cbor) now emit an empty payload (e.g.,
{}) and set the content-type header for events with no payload members. REST protocol (restJson) continue to omit the body and content-type as before.Why is this change needed?
RPC protocols must always serialize a body even when there are no payload members, unlike REST protocols which omit it.
How was this validated?
What should reviewers focus on?
EventSerializer.writeStruct(emitEmptyPayload || hasPayloadMembers)true/falsevalues passed at each protocol call siteAdditional Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.