Skip to content

[MAINTENANCE] Add string type hints to attribute getter parameters#33

Open
beatrycze-volk wants to merge 3 commits into
slub:masterfrom
beatrycze-volk:functions2
Open

[MAINTENANCE] Add string type hints to attribute getter parameters#33
beatrycze-volk wants to merge 3 commits into
slub:masterfrom
beatrycze-volk:functions2

Conversation

@beatrycze-volk

Copy link
Copy Markdown
Collaborator

Depends on #31

Drop support for PHP 7.4, making PHP 8.2 the new minimum requirement for the project.

This update also includes bumping PHPStan and PHPUnit to their latest major versions, ensuring compatibility with modern PHP environments and leveraging new features from these development tools.
Migrate PHPUnit test method annotations from the legacy `@test` docblock tag to the native PHP 8 `#[Test]` attribute syntax. This aligns the test suite with modern PHP practices as part of the ongoing PHP version update.
Explicitly declare parameter types for attribute getters to improve code clarity and enable better static analysis.
@beatrycze-volk beatrycze-volk added this to the PHP MODS Reader 1.0.0 milestone Jun 22, 2026
@beatrycze-volk beatrycze-volk self-assigned this Jun 22, 2026
@beatrycze-volk beatrycze-volk added the maintenance Routine updates, code refactoring, and general repository upkeep label Jun 22, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@beatrycze-volk beatrycze-volk added the php Pull requests that update PHP code label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Routine updates, code refactoring, and general repository upkeep php Pull requests that update PHP code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant