Skip to content

Implement form_post response mode#337

Merged
cicnavi merged 29 commits into
simplesamlphp:wip-version-7from
Harm-r:wip-version-7-form-post
Jun 8, 2026
Merged

Implement form_post response mode#337
cicnavi merged 29 commits into
simplesamlphp:wip-version-7from
Harm-r:wip-version-7-form-post

Conversation

@Harm-r

@Harm-r Harm-r commented May 19, 2026

Copy link
Copy Markdown

This pull request implements support for the form_post response mode, specifically:

To achieve this, I've refactored the code to use an instance of the ResponseModeInterface for returning responses, instead of a hardcoded queryDelimiter parameter.

This work has been done during the 11th cycle of the T&I Incubator at GÉANT.

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 43.22344% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.80%. Comparing base (6342151) to head (02f9ad9).
⚠️ Report is 3 commits behind head on wip-version-7.

Files with missing lines Patch % Lines
src/Server/Exceptions/OidcServerException.php 0.00% 56 Missing ⚠️
src/Server/Grants/AuthCodeGrant.php 0.00% 15 Missing ⚠️
src/Forms/ClientForm.php 75.00% 13 Missing ⚠️
src/Services/Container.php 0.00% 11 Missing ⚠️
src/Entities/ClientEntity.php 0.00% 9 Missing ⚠️
src/Factories/RequestRulesManagerFactory.php 0.00% 8 Missing ⚠️
src/ModuleConfig.php 0.00% 6 Missing ⚠️
src/Server/AuthorizationServer.php 0.00% 5 Missing ⚠️
src/Server/Grants/ImplicitGrant.php 50.00% 5 Missing ⚠️
src/Server/ResponseModes/FragmentResponseMode.php 0.00% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##             wip-version-7     #337      +/-   ##
===================================================
- Coverage            46.88%   46.80%   -0.09%     
- Complexity            2041     2070      +29     
===================================================
  Files                  166      171       +5     
  Lines                 8662     8848     +186     
===================================================
+ Hits                  4061     4141      +80     
- Misses                4601     4707     +106     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cicnavi cicnavi self-requested a review May 19, 2026 12:57

@cicnavi cicnavi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes to the PR. Before merging, please check if those are ok with you @Harm-r .

@Harm-r

Harm-r commented Jun 5, 2026

Copy link
Copy Markdown
Author

Looks good to me! A lot cleaner, thank you @cicnavi

@cicnavi cicnavi merged commit cb5c1c9 into simplesamlphp:wip-version-7 Jun 8, 2026
7 of 9 checks passed
@cicnavi

cicnavi commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants