Skip to content

Port 'Expose Settings.xml Visibility' from machine#310

Open
Copilot wants to merge 1 commit into
mainfrom
copilot/port-expose-settings-xml-visibility
Open

Port 'Expose Settings.xml Visibility' from machine#310
Copilot wants to merge 1 commit into
mainfrom
copilot/port-expose-settings-xml-visibility

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Ports changes from sillsdev/machine#412 — exposes the <Visibility> field from Paratext Settings.xml.

Changes

  • ParatextProjectSettings — Added visibility: Optional[str] = None field
  • ParatextProjectSettingsParserBase — Reads <Visibility> element and passes it to the constructor
  • Tests — Added test_parse() to both file and zip parser tests asserting all settings fields; updated _create_settings() helper to include "Public" for visibility
parser = FileParatextProjectSettingsParser(project_path)
settings = parser.parse()
assert settings.visibility == "Public"  # read from <Visibility>Public</Visibility> in Settings.xml

This change is Reviewable

Copilot AI linked an issue Jun 9, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Port relevant changes from pull request 412 to machine.py Port 'Expose Settings.xml Visibility' from machine Jun 9, 2026
Copilot AI requested a review from ddaspit June 9, 2026 19:07

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@ddaspit ddaspit marked this pull request as ready for review June 15, 2026 13:48

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on copilot[bot]).

@codecov-commenter

codecov-commenter commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.69%. Comparing base (9062a9d) to head (6797e82).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   91.68%   91.69%   +0.01%     
==========================================
  Files         359      359              
  Lines       23425    23459      +34     
==========================================
+ Hits        21477    21511      +34     
  Misses       1948     1948              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit force-pushed the copilot/port-expose-settings-xml-visibility branch from 5b9b0ff to 6797e82 Compare June 15, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port 'Expose Settings.xml Visibility'

4 participants