Port 'Expose Settings.xml Visibility' from machine#310
Open
Copilot wants to merge 1 commit into
Open
Conversation
Copilot
AI
changed the title
[WIP] Port relevant changes from pull request 412 to machine.py
Port 'Expose Settings.xml Visibility' from machine
Jun 9, 2026
Enkidu93
approved these changes
Jun 15, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
ddaspit
approved these changes
Jun 15, 2026
ddaspit
left a comment
Contributor
There was a problem hiding this comment.
@ddaspit reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on copilot[bot]).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 91.68% 91.69% +0.01%
==========================================
Files 359 359
Lines 23425 23459 +34
==========================================
+ Hits 21477 21511 +34
Misses 1948 1948 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5b9b0ff to
6797e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports changes from sillsdev/machine#412 — exposes the
<Visibility>field from ParatextSettings.xml.Changes
ParatextProjectSettings— Addedvisibility: Optional[str] = NonefieldParatextProjectSettingsParserBase— Reads<Visibility>element and passes it to the constructortest_parse()to both file and zip parser tests asserting all settings fields; updated_create_settings()helper to include"Public"for visibilityThis change is