Exclude .wav files from Webonary upload#922
Merged
Merged
Conversation
The export pipeline already converts .wav to .mp3 via WavConverter in CopyFileSafely when IsWebExport is true. However, IsSupportedWebonaryFile still listed .wav as an accepted format, so any .wav that slipped through (e.g. if conversion failed) was uploaded as-is. Remove .wav from the supported list so unconverted files are excluded rather than uploaded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasonleenaylor
force-pushed
the
fix/exclude-wav-from-webonary-upload
branch
from
ce720eb to
ebb7295
Compare
johnml1135
requested review from
Copilot and
johnml1135
and removed request for
johnml1135
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Webonary upload filtering logic to prevent raw .wav audio files from being uploaded (favoring the existing .wav → .mp3 conversion path used during web export).
Changes:
- Removed
.wavfromUploadToWebonaryController.IsSupportedWebonaryFilesupported extensions list. - Updated
IsSupportedWebonaryFile_reportsAccuratelyto assert that.wavis rejected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Src/xWorks/UploadToWebonaryController.cs | Removes .wav from the supported upload extensions checked during Webonary upload recursion. |
| Src/xWorks/xWorksTests/UploadToWebonaryControllerTests.cs | Updates the supported-file test to expect .wav to be unsupported. |
johnml1135
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.wavfrom the supported file extensions inIsSupportedWebonaryFile, so raw.wavfiles are no longer uploaded to Webonary..wavto.mp3viaWavConverter.WavToMp3inCopyFileSafelywhenIsWebExportis true. However,.wavwas still listed as a supported upload format, meaning any.wavthat survived into the export directory (e.g. if conversion failed) would be uploaded as-is -- large, uncompressed, and unintended..wavto be rejected.Test plan
IsSupportedWebonaryFile_reportsAccuratelytest passes with updated assertionCreated in collaboration with Claude Code
This change is