fix(mod_conference): retry active input before silence#3047
Open
roblindsay24 wants to merge 1 commit into
Open
fix(mod_conference): retry active input before silence#3047roblindsay24 wants to merge 1 commit into
roblindsay24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3024.
Summary
audio_bufferwrite from the conference input threadWhy
The reported distortion happens when the mixer sees no complete input frame and drops into the global silence branch even though an input thread is actively feeding a continuous source. This patch does not replay the last frame and does not synthesize substitute audio, so it should be safer for FSK/modem-like tones than concealment approaches. It only gives the real input thread a short condition-variable window at the exact point where the mixer is about to insert silence.
Validation
git diff --check -- src/mod/applications/mod_conference/conference_loop.c src/mod/applications/mod_conference/conference_member.c src/mod/applications/mod_conference/mod_conference.c src/mod/applications/mod_conference/mod_conference.hsignalwire/freeswitch-public-ci-base:bookworm-amd64and started the official Sofia-SIP + FreeSWITCH CI build sequence locally; the full build did not complete before my local timeout, so this PR still needs normal CI/maintainer runtime validation.