[codex] bump go-ethereum to v1.15.7-sei-17#3657
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 8ebd52e. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
A minimal, mechanically clean bump of the sei-protocol/go-ethereum fork replace directive from v1.15.7-sei-16 to v1.15.7-sei-17, touching only go.mod and go.sum. The diff itself is correct; the substantive risk lives in the fork's source changes, which are not visible in this PR.
Findings: 0 blocking | 3 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The go.sum update is internally consistent: the fork's h1 source hash changed (sei-16 -> sei-17) while the /go.mod hash stayed identical, indicating the fork's go.mod was unchanged and only source code differs — as expected for this kind of bump.
- The actual behavioral changes in the fork (sei-16 -> sei-17) are not part of this diff and cannot be reviewed here. Since the PR is labeled
app-hash-breaking, confirm the EVM/consensus impact has been validated (the PR citesgo mod verifyandgo test ./x/evm/... ./evmrpc/...) and that node operators are aware this requires a coordinated upgrade. - Second-opinion passes were effectively empty: Codex reported no material findings but could not run Go verification (sandbox had Go 1.24.13, not the required 1.25.6, with network blocked); the Cursor review file was empty/produced no output.
There was a problem hiding this comment.
A minimal dependency bump of the Sei go-ethereum fork (v1.15.7-sei-16 → sei-17) with a consistent go.sum refresh; the go.mod/go.sum changes are internally coherent. The only concern is an undocumented CI change (verify: false) bundled in alongside the dependency bump.
Findings: 0 blocking | 4 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The
verify: falsechange in .github/workflows/golangci.yml is unrelated to the dependency bump and is not mentioned in the PR description. It disables golangci-lint-action's config-schema verification, slightly weakening CI signal. Consider documenting why it's needed (e.g. a v2.8.0 schema-validation incompatibility) or splitting it into its own PR. - The fork's actual code changes (sei-16 → sei-17) cannot be reviewed from this repository and aren't summarized in the PR; given the
app-hash-breakinglabel, a brief note in the description on what changed in the fork would help reviewers assess consensus risk. - Cursor's second-opinion review produced no output (empty file); Codex reported no material findings.
- 1 suggestion(s)/nit(s) flagged inline on specific lines.
| with: | ||
| version: v2.8.0 | ||
| args: --timeout 10m0s | ||
| verify: false |
There was a problem hiding this comment.
[suggestion] This verify: false addition is unrelated to the go-ethereum bump described in the PR. It disables golangci-lint-action's verification of the .golangci.yml config against its schema, which reduces CI's ability to catch malformed lint config. If it's a workaround for a v2.8.0 schema-validation issue, please note the reason; otherwise consider keeping it in a separate, dedicated change.
There was a problem hiding this comment.
guh I guess I need to housetrain codex better
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
==========================================
- Coverage 59.14% 58.18% -0.97%
==========================================
Files 2262 2178 -84
Lines 187031 177408 -9623
==========================================
- Hits 110625 103226 -7399
+ Misses 66456 65023 -1433
+ Partials 9950 9159 -791
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
masih
left a comment
There was a problem hiding this comment.
Extra context needed to explain why golangci verify is disabled here
There was a problem hiding this comment.
Routine dependency bump of the Sei go-ethereum fork from v1.15.7-sei-16 to v1.15.7-sei-17 with a refreshed go.sum, plus an unrelated CI change disabling golangci-lint config verification. The go.mod/go.sum changes are consistent and well-formed; the only points of note are the CI tweak and the fact that the fork's actual contents can't be reviewed from this diff.
Findings: 0 blocking | 5 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The substantive change is the go-ethereum fork bump, but the actual source delta between sei-16 and sei-17 is not visible in this diff. Since the PR is labeled
app-hash-breaking, reviewers should confirm the fork changelog/commits and that the listed validation (go mod verify,go test ./x/evm/... ./evmrpc/...) plus app-hash regression tests actually passed before merge. - go.mod/go.sum changes are consistent: the replace directive, both go.sum hash lines, and the unchanged go.mod hash all line up correctly for the version bump.
- Codex's second-opinion pass reported no material findings (it could not run Go validation due to a Go 1.24 sandbox and blocked network).
- Cursor's second-opinion review file (
cursor-review.md) was empty — that pass produced no output. - 1 suggestion(s)/nit(s) flagged inline on specific lines.
| with: | ||
| version: v2.8.0 | ||
| args: --timeout 10m0s | ||
| verify: false |
There was a problem hiding this comment.
[suggestion] Adding verify: false disables golangci-lint-action's validation of .golangci.yml against its JSON schema. This is unrelated to a go-ethereum bump and silences config-schema errors going forward, so a malformed lint config could slip through unnoticed. Consider whether this is intentional/permanent, and if it's only a workaround for a transient v2.8.0 schema mismatch, add a comment noting why and when it can be removed.
08bfb65 to
8ebd52e
Compare
There was a problem hiding this comment.
Mechanical bump of the sei-protocol/go-ethereum fork replacement from v1.15.7-sei-16 to v1.15.7-sei-17 with refreshed go.sum checksums; the diff is internally consistent and correct, but the actual behavioral changes live in the fork and cannot be reviewed from this PR.
Findings: 0 blocking | 3 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The substantive changes are in the go-ethereum fork between sei-16 and sei-17 and are not visible in this diff. Since the PR is labeled
app-hash-breakingandbackport release/v6.6, confirm the fork delta is consensus-safe, intentionally app-hash-breaking (coordinated with the upgrade/release that activates it), and that the Validation steps (go mod verify,go test ./x/evm/... ./evmrpc/...) actually passed before merge. - The
go.sumchange correctly updates only the packageh1:hash while leaving the/go.modhash unchanged, consistent with a source-only fork change. No issue, just confirming integrity. - Cursor's second-opinion review file (
cursor-review.md) was empty, so no Cursor findings were available to incorporate. Codex reported no material findings but noted it could not validate (sandbox had Go 1.24.13, cannot fetch the required Go 1.25.6 toolchain), so neither external pass independently verified the build/tests.
|
Successfully created backport PR for |
Summary
v1.15.7-sei-16tov1.15.7-sei-17.go.sumchecksums withgo mod tidy.Impact
This updates the EVM dependency fork used by the existing
github.com/ethereum/go-ethereumreplace directive without changing the upstream module requirement shape.Validation
go mod verifygo test ./x/evm/... ./evmrpc/...