SSH: fix _ComaStrField length calculation#5010
Merged
Merged
Conversation
AI-Assisted: yes (Claude Sonnet 4.6)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5010 +/- ##
=======================================
Coverage 80.02% 80.03%
=======================================
Files 384 384
Lines 95622 95624 +2
=======================================
+ Hits 76526 76532 +6
+ Misses 19096 19092 -4
🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This PR fixes SSH
_ComaStrFieldlength calculation._ComaStrFieldis used inNameListwhich is used withSSHKexInit:Reproduce:
The current implementation considers
namesas list and not bytes and return1forlengthin this example.