Revert A2 fast optimizations#295
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts the
NAM/wavenet/a2_fast.cppchanges from #277 and addsexample_models/A2.namas an example A2 model.Context
Follow-up testing in #290 showed that the #277 A2 fast-path optimizations are highly compiler/target dependent. Some compiler contexts see speedups, while others regress significantly.
On Apple M1 + AppleClang 16, benchmarking
example_models/A2.namagainst the parent of #277 showed:slim=1.0/ 8ch: ~29% slower by mean, ~30% slower by medianslim=0.0/ 3ch: ~2% faster by mean, ~3% faster by medianGiven the 8-channel regression, this restores the prior
a2_fast.cppimplementation while we decide whether to reintroduce these paths behind compiler/configuration flags.Changes
NAM/wavenet/a2_fast.cppexample_models/A2.namSlimmableContainermax_value=0.5max_value=1.0Validation
Built
benchmodelsuccessfully with:cmake -S . -B build -DCMAKE_BUILD_TYPE=Release cmake --build build --target benchmodeldiff