✨ Align @string values according to BibtexFormat.value_column#558
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…arately Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
value_columndocstring has claimed since the original writer draft (#356) that String blocks are aligned, but_treat_stringnever applied any alignment. This implements it, with the semantics decided explicitly:@string{prefix — entry and string values thus each align among themselves (not at the same absolute column, since the prefixes differ)."auto": the longest key now considers both entry field keys and string keys, so a single consistent column is used. Note this can shift entry alignment in libraries with long string keys.Default (
value_column = 0) output is unchanged.Stacked on #555 (uses the
_val_indent_stringrename) — merge #555 first; this PR's diff will then shrink to the writer/test changes only.Follow-up to the discussion on #555 / #542.
🤖 Generated with Claude Code